Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct broken codemirror-lang-graphql in node 22 #4514

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

AndrewBastin
Copy link
Member

This PR intends to fix the issues with building codemirror-lang-graphql in Node 22.

The issue is caused by Node 22 dropping the assert keyword for import assertions. We use rollup-plugin-ts as the plugin to parse typescript files, which uses assert keyword inside it.

What's changed

  • Move to @rollup/plugin-typescript and remove rollup-plugin-ts and rollup-plugin-dts.
  • Update prepare script to also generate declaration file for codemirror-lang-graphql package.

Notes to reviewers

Do make sure the GraphQL syntax highlighting still works and is stable across SH, Web and Desktop across debug and production modes.

@jamesgeorge007 jamesgeorge007 merged commit 6ad2b5a into hoppscotch:patch Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants