fix: correct broken codemirror-lang-graphql in node 22 #4514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the issues with building
codemirror-lang-graphql
in Node 22.The issue is caused by Node 22 dropping the
assert
keyword for import assertions. We userollup-plugin-ts
as the plugin to parse typescript files, which usesassert
keyword inside it.What's changed
@rollup/plugin-typescript
and removerollup-plugin-ts
androllup-plugin-dts
.codemirror-lang-graphql
package.Notes to reviewers
Do make sure the GraphQL syntax highlighting still works and is stable across SH, Web and Desktop across debug and production modes.