HSB-497 chore: user deletetion if not solo team owner #4508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewBastin
requested changes
Nov 4, 2024
AndrewBastin
approved these changes
Nov 4, 2024
|
Would it be possible to control whether the workspace is deleted automatically when the last owner is removed, instead of blocking the deletion, through a configuration variable? This could make the behavior more flexible depending on the use case. |
|
Or perhaps even add a |
|
@RaHehl that could be something we can tackle down the line. We are still a bit skeptical about having this in the GUI, but this could be something we can add in the API as an initial start. |
AndrewBastin
force-pushed
the
feat/user-delete-condition
branch
from
3db0b02 to
ef48f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HSB-497
What's changed
This PR updated the user deletion. Previously if a user a team owner, that user can not be deleted.
Now, a user can be deleted if he is not solo team owner in any of teams.
Notes to reviewers
3 ways a user can be deleted.