Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(desktop): add CA cert and HTTP proxy support for native interceptor #4491

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat(desktop): add CA cert and HTTP proxy support for native interceptor #4491

merged 1 commit into from
Oct 29, 2024
+91 −13

Conversation

CuriousCorrelation
Copy link
Contributor

@CuriousCorrelation CuriousCorrelation commented Oct 29, 2024 •
edited
Loading

Description

Adds HTTP/HTTPS/SOCKS proxy support to the native interceptor in the desktop app. The native interceptor now allows users to:

  • Enable/disable proxy usage
  • Configure proxy URL with support for:
    • HTTP/HTTPS/SOCKS protocols
    • Basic Auth and NTLM authentication (via URL)
    • Username/password in URL format

Changes

  • Added proxy configuration UI in NativeInterceptor settings
  • Implemented proxy persistence using local storage
  • Extended RequestDef type to include proxy information
  • Added proxy URL validation and handling in the native interceptor service

Fix

  • Added IconLucideFileBadge icon to common package for consistency (this is a fix for web-app)

Closes HFE-639

@CuriousCorrelation CuriousCorrelation changed the base branch from main to next October 29, 2024 10:43
@CuriousCorrelation CuriousCorrelation marked this pull request as ready for review October 29, 2024 11:01
@CuriousCorrelation @AndrewBastin
feat(desktop): add CA cert and HTTP proxy support for native interceptor
000bd08 
fix: missing `IconLucideFileBadge` icon in common
@AndrewBastin AndrewBastin merged commit 75bac21 into hoppscotch:next Oct 29, 2024
1 check passed
amk-dev pushed a commit to amk-dev/hoppscotch that referenced this pull request Nov 26, 2024
@CuriousCorrelation @amk-dev
feat(desktop): add CA cert and HTTP proxy support for native intercep…
55d8bef 
…tor (hoppscotch#4491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin AndrewBastin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CuriousCorrelation @AndrewBastin