feat: support for binary body #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amk-dev
force-pushed
the
feat/binary-body
branch
from
aa359fd to
92d9d24
Compare
amk-dev
force-pushed
the
feat/binary-body
branch
from
92d9d24 to
86c8c50
Compare
jamesgeorge007
requested changes
Oct 28, 2024
There was a problem hiding this comment.
There's an exception while setting Agent as the interceptor. For now, we've decided to show a warning via the inspector regarding the support.
The following issues can be revisited:
- Say, there's a request open with
application/octet-streamas the content type and a file chosen. The file is lost while navigating to another tab and returning. - Save the above request in a collection, export and re-import. Open the request and observe the tab appear in the dirty state even though no updates happened in between.
amk-dev
force-pushed
the
feat/binary-body
branch
from
7b2d7fd to
c9991f4
Compare
amk-dev
force-pushed
the
feat/binary-body
branch
from
b40211d to
6e54ea6
Compare
jamesgeorge007
force-pushed
the
feat/binary-body
branch
from
ac56eca to
0452bd8
Compare
jamesgeorge007
approved these changes
Nov 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for sending binary data as body.
since the binary file is not exported, In
hoppscotch-cli, added some changes to not error the request out, like how multipart/form-data is behaving right now.feat: handle binary files in body hoppscotch-extension#307 adds support for binary files in our browser extension.