Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): introducing ability to set custom collection import size limit #4440

Conversation

JoelJacobStephen
Copy link
Contributor

Ticket

Description

This PR adds the ability to set custom collection import size limit and change it from the default value of 10MB. The size limit for selfhost-web will now be 50MB.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@JoelJacobStephen JoelJacobStephen force-pushed the feat/update-collection-import-size branch from 68a0093 to 93d95d9 Compare October 15, 2024 23:45
@JoelJacobStephen JoelJacobStephen marked this pull request as ready for review October 15, 2024 23:45
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideal candidates for platformFeatureFlags are boolean properties indicating whether a given feature applies to the active platform. In this case, it'd be appropriate to introduce the collectionImportSizeLimit property at the top-level platform definition or say, within a new field like limits.

@AndrewBastin, appreciate your thoughts on the convention here.

EDIT: Discussed separately, we'll be including the collectionImportSizeLimit property within a new limits field. This field can be extended to impose limits for file uploads with multipart/form-data content type when workspace syncing is enabled down the line.

@AndrewBastin
Copy link
Member

I guess, the limits field is not a bad idea, I actually recommended feature flags mostly because there was no clean place to put it and a category for just this limit is weird, are there any other limits that there is a chance for it to come up ?

@JoelJacobStephen JoelJacobStephen force-pushed the feat/update-collection-import-size branch from 93d95d9 to bca57d8 Compare October 17, 2024 23:57
@JoelJacobStephen
Copy link
Contributor Author

Ideal candidates for platformFeatureFlags are boolean properties indicating whether a given feature applies to the active platform. In this case, it'd be appropriate to introduce the collectionImportSizeLimit property at the top-level platform definition or say, within a new field like limits.

@AndrewBastin, appreciate your thoughts on the convention here.

EDIT: Discussed separately, we'll be including the collectionImportSizeLimit property within a new limits field. This field can be extended to impose limits for file uploads with multipart/form-data content type when workspace syncing is enabled down the line.

@jamesgeorge007 I have implemented the new limits field.

@JoelJacobStephen JoelJacobStephen changed the title feat: introducing ability to set custom collection import size limit feat(common): introducing ability to set custom collection import size limit Oct 18, 2024
@jamesgeorge007 jamesgeorge007 force-pushed the feat/update-collection-import-size branch from bca57d8 to af0a20c Compare October 23, 2024 13:00
@jamesgeorge007 jamesgeorge007 merged commit 0e00eeb into hoppscotch:next Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants