-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): introducing ability to set custom collection import size limit #4440
feat(common): introducing ability to set custom collection import size limit #4440
Conversation
68a0093
to
93d95d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideal candidates for platformFeatureFlags
are boolean properties indicating whether a given feature applies to the active platform. In this case, it'd be appropriate to introduce the collectionImportSizeLimit
property at the top-level platform definition or say, within a new field like limits
.
@AndrewBastin, appreciate your thoughts on the convention here.
EDIT: Discussed separately, we'll be including the collectionImportSizeLimit
property within a new limits
field. This field can be extended to impose limits for file uploads with multipart/form-data
content type when workspace syncing is enabled down the line.
I guess, the limits field is not a bad idea, I actually recommended feature flags mostly because there was no clean place to put it and a category for just this limit is weird, are there any other limits that there is a chance for it to come up ? |
93d95d9
to
bca57d8
Compare
@jamesgeorge007 I have implemented the new limits field. |
bca57d8
to
af0a20c
Compare
Ticket
Description
This PR adds the ability to set custom collection import size limit and change it from the default value of 10MB. The size limit for selfhost-web will now be 50MB.
Checks