Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sh-admin): bump dependencies #4433

Conversation

JoelJacobStephen
Copy link
Contributor

@JoelJacobStephen JoelJacobStephen commented Oct 13, 2024

Ticket

  • Closes HFE-619

Description

This PR bumps the dependencies in the sh-admin repo.

@urql/vue is pinned to v1.4.0 since v1.4.1 uses shallowRef() for data variable from useQuery() composable that affects the behavior. For instance, the list of invites isn't immediately updated while revoking pending invites.

const pendingInvites = computed({
get: () => data.value?.infra.invitedUsers,
set: (value) => {
if (!value) return;
data.value!.infra.invitedUsers = value;
},
});

There are type errors arising in the above page source that are to be revisited down the line.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@JoelJacobStephen JoelJacobStephen force-pushed the refactor/sh-admin-bump-dependencies branch from 4bd5d86 to 89f8fdc Compare October 18, 2024 00:05
@JoelJacobStephen JoelJacobStephen marked this pull request as ready for review October 18, 2024 00:07
@jamesgeorge007 jamesgeorge007 changed the base branch from patch to next October 21, 2024 09:22
@jamesgeorge007 jamesgeorge007 force-pushed the refactor/sh-admin-bump-dependencies branch 3 times, most recently from 4d5c8b6 to 2277ae6 Compare October 21, 2024 11:54
JoelJacobStephen and others added 4 commits October 23, 2024 06:15
Remove stale dependencies.
`v1.4.1` uses `shallowRef()` for `data` variable from `useQuery()` composable that affects the behavior.

Resolve type errors.
@jamesgeorge007 jamesgeorge007 force-pushed the refactor/sh-admin-bump-dependencies branch from 2277ae6 to c367a9a Compare October 23, 2024 13:15
@jamesgeorge007 jamesgeorge007 changed the title refactor(sh-admin): bump dependencies in the sh-admin repo chore(sh-admin): bump dependencies Oct 23, 2024
@jamesgeorge007 jamesgeorge007 merged commit 79aefed into hoppscotch:next Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants