feat: show login dialogue for features behind login #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested changes
Oct 21, 2024
There was a problem hiding this comment.
There's an edge case with the Import from Another Workspace action where logging in via the above action and proceeding to choose a workspace to import from only lists Personal or will show an infinite spinner until initiating a page reload or expanding the workspace selector to fetch the list of workspaces.
This can also be reproduced in the pre-existing implementation by choosing the Import from Another Workspace action immediately upon logging in.
import-from-another-workspace-edgecase.mov
jamesgeorge007
approved these changes
Nov 4, 2024
nivedin
approved these changes
Nov 8, 2024
jamesgeorge007
force-pushed
the
feat/show-login-on-login-enabled-features
branch
from
5bf8957 to
bb25e33
Compare
jamesgeorge007
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HP-306 HFE-616.
Changes
Previously, we hide the features that required login. This PR shows the features, but when the user tries to trigger it, it will open the login dialogue.
This PR made this change to these features