Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to configure query params encoding for requests #4412

Merged
merged 12 commits into from
Oct 23, 2024

Conversation

Pranay-Pandey
Copy link
Contributor

@Pranay-Pandey Pranay-Pandey commented Oct 7, 2024

Closes #2829

Add optional setting of encoding the URL parameters in the request. A new setting option is introduced which can be toggled between auto, disable and auto.
Also have fixed the bug with preProcessRequest function where double encoding was happening.

What's changed

  • New setting section named General introduced and moved language, experiments section within
  • Encoding setting will decide whether to encode the URL parameters

Preview

image

nivedin
nivedin previously approved these changes Oct 10, 2024
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranay-Pandey thank you for the contribution, I have made some minor changes to the PR

@jamesgeorge007 jamesgeorge007 changed the base branch from main to next October 22, 2024 11:28
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be good to display a warning (might lead to malformed requests, etc) via the inspector while the encoding preference is set to Disable as an enhancement down the line.

@jamesgeorge007 jamesgeorge007 changed the title feat: add parameter encoding in requests feat: add the ability to configure query params encoding for requests Oct 23, 2024
@jamesgeorge007 jamesgeorge007 merged commit cf0978b into hoppscotch:next Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: query parameters are escaped implicitly
3 participants