Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fallback for type field in restTabState schema #4398

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Oct 3, 2024

This PR fixes the issue with rest tab schema where the tab didn't have type property that lead's to app crashing.

What's changed

A catch was added to the type property where the default value will be set to "request"

@nivedin nivedin requested a review from jamesgeorge007 October 3, 2024 12:18
@jamesgeorge007 jamesgeorge007 changed the title feat: add loading state for import actions (#4217) fix: add fallback for type key in restTabState schema Oct 3, 2024
@jamesgeorge007 jamesgeorge007 changed the title fix: add fallback for type key in restTabState schema fix: add fallback for type field in restTabState schema Oct 3, 2024
@jamesgeorge007 jamesgeorge007 merged commit 8535004 into next Oct 3, 2024
1 check passed
@jamesgeorge007 jamesgeorge007 deleted the fix/rest-tab-schema-type-bug branch October 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants