Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve personal environments correctly while editing via quick peek #4384

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

shipko
Copy link
Contributor

@shipko shipko commented Sep 29, 2024

Previously, attempting to edit the active environment under personal workspace entry via Environment Quick Peek will result in the modal getting displayed with variables from another environment entry. This PR includes a fix for the same.

Closes #4380

What's changed

Fixed a function to define current env by name

  • Not Completed
  • Completed

@shipko
Copy link
Contributor Author

shipko commented Oct 8, 2024

@AndrewBastin please, review it.

@nivedin nivedin self-requested a review October 8, 2024 07:05
@jamesgeorge007 jamesgeorge007 changed the title fix(quick-edit-bug): fix bug (#4380) fix: resolve personal environments correctly while editing via quick peek Oct 10, 2024
@jamesgeorge007 jamesgeorge007 merged commit bb21b13 into hoppscotch:patch Oct 10, 2024
1 check passed
@shipko shipko deleted the quick-edit-bug branch October 15, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants