Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save api response #4382

Merged
merged 34 commits into from
Sep 30, 2024
Merged

feat: save api response #4382

merged 34 commits into from
Sep 30, 2024

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Sep 26, 2024

Closes HFE-534 #1875

This feature adds the ability to save responses as example for a saved request.

Screen.Recording.2024-09-27.at.10.50.03.PM.1.mov

TODO

  • Add support for Shared Workspaces
  • Add Import from Postman, OpenAPI
  • Fix bug while editing RAW content

@nivedin nivedin force-pushed the feat/save-api-response branch 2 times, most recently from 9171027 to c626f7c Compare September 27, 2024 14:57
@nivedin nivedin marked this pull request as ready for review September 27, 2024 17:57
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • While creating a response example with the same name as a pre-existing entry, let's add a new entry rather than overwriting the former. This needs to be extended such that editing the name for a given entry to an existing one is permitted.

Discussed separately, we'll keep this flow as is for now and iterate down the line.

response-eg-duplicate-overwrites.mov
  • Any actions (edit, delete & duplicate) other than creation aren't persisted for a response eg under a given request when opened under a tab. While actions performed when the tab is closed persist.

  • The New request modal doesn't permit request creation when the currently active tab has a response example open.

  • Response examples open under tabs are dissociated during parent request/collection move/reorder operations (relatively lower priority, can be revisited separately).

    response-eg-issues.mov

@nivedin
Copy link
Member Author

nivedin commented Sep 30, 2024

  • While creating a response example with the same name as a pre-existing entry, let's add a new entry rather than overwriting the former. This needs to be extended such that editing the name for a given entry to an existing one is permitted.

Discussed separately, we'll keep this flow as is for now and iterate down the line.

response-eg-duplicate-overwrites.mov

  • Any actions (edit, delete & duplicate) other than creation aren't persisted for a response eg under a given request when opened under a tab. While actions performed when the tab is closed persist.

  • The New request modal doesn't permit request creation when the currently active tab has a response example open.

  • Response examples open under tabs are dissociated during parent request/collection move/reorder operations (relatively lower priority, can be revisited separately).

    response-eg-issues.mov
    

Done ✅

@nivedin nivedin force-pushed the feat/save-api-response branch from 13a9bff to 33b5c39 Compare September 30, 2024 10:20
@nivedin nivedin force-pushed the feat/save-api-response branch from 31d0164 to a8e8ab6 Compare September 30, 2024 13:30
@jamesgeorge007 jamesgeorge007 merged commit 58857be into next Sep 30, 2024
1 check passed
@jamesgeorge007 jamesgeorge007 deleted the feat/save-api-response branch September 30, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants