Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for comments on application/json request body #4335

Merged
merged 12 commits into from
Oct 1, 2024

Conversation

anwarulislam
Copy link
Member

@anwarulislam anwarulislam commented Sep 9, 2024

Closes HFE-574

This PR introduces support for comments in the ⁠application/json request body.

What's changed

Currently, comments are not allowed in ⁠application/json request bodies, making it difficult to add explanatory notes or temporarily disable parts of the JSON structure. This can lead to less readable and maintainable code, especially for large or complex JSON payloads.

@liyasthomas liyasthomas linked an issue Sep 10, 2024 that may be closed by this pull request
1 task
@gabrielrufino
Copy link

❤️

@anwarulislam anwarulislam marked this pull request as ready for review September 18, 2024 12:19
@anwarulislam anwarulislam changed the base branch from main to next September 30, 2024 06:38
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jamesgeorge007 jamesgeorge007 merged commit dcdcdeb into hoppscotch:next Oct 1, 2024
1 check passed
@shuaixr shuaixr mentioned this pull request Oct 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Use comments in request body
4 participants