feat: duplicate global environment under team workspaces #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
changed the title
jamesgeorge007
force-pushed
the
feat/duplicate-global-environment-team-workspace
branch
5 times, most recently
from
14a348b
to
f2117bf
Compare
balub
suggested changes
Sep 11, 2024
There was a problem hiding this comment.
I think the FE does not subscribe to the environment-created subscription, I need to reload the screen for the newly created environment to pop up.
WhatsApp.Video.2024-09-11.at.12.44.47_6383bb3c.mp4
@jamesgeorge007 can you confirm ??
Discussed separately, it was found specific to the local environment setup. |
jamesgeorge007
force-pushed
the
feat/duplicate-global-environment-team-workspace
branch
from
1716558
to
9d5e07a
Compare
For actions over environments.
Applicable to team workspaces.
jamesgeorge007
force-pushed
the
feat/duplicate-global-environment-team-workspace
branch
from
9d5e07a
to
a2e51df
Compare
jamesgeorge007
deleted the
feat/duplicate-global-environment-team-workspace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplicate global environment action was specific to the personal workspace, where the entries were added and hidden while at a team workspace with #4245. This PR re-enables the action under team workspaces and extends support. Also, the following changes are added alongside applicable to team workspaces:
- Duplicatesuffix for duplicated environment entries.Closes HFE-575.
Preview
duplicate-global-environment-team-workspaces.mov
What's changed
duplicateGlobalEnvironmentLoading(keeps track of the n/w call status and dismisses the context menu) &showContextMenuLoadingState(Indicates the context menu is to be displayed during the n/w call in a team workspace) and defines a new eventduplicate-global-environmentunder theEnvironmentsMyEnvironmentcomponent.Environmentscomponent to trigger thecreateTeamEnvironmentGQL mutation with the global environment variables in scope.getEnvActionErrrorMessageabstracting the error messages reused for environment-related actions.- Duplicatesuffix to duplicated environment names under team workspaces.Notes to reviewers
Please ensure to cross-check the error message updates once with the newly added helper function.