Add some notes

hopkings2008 · Dec 19, 2019 · 08930b6 · 08930b6
1 parent 6ebf234
commit 08930b6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/apiserver/facades/agent/uniter/uniter.go b/apiserver/facades/agent/uniter/uniter.go
@@ -1474,6 +1474,7 @@ func (u *UniterAPI) EnterScope(args params.RelationUnits) (params.ErrorResults,
 			// reflects the purpose of the attribute value. We'll deprecate private-address.
 			settings["ingress-address"] = ingressAddress
 		} else {
+			// Is this worth logging if there is no error?
 			logger.Warningf("cannot set ingress/egress addresses for unit %v in relation %v: %v",
 				unitTag.Id(), relTag, err)
 		}

diff --git a/core/raftlease/store.go b/core/raftlease/store.go
@@ -257,6 +257,8 @@ func (s *Store) runOnLeader(command *Command, stop <-chan struct{}) error {
 
 	select {
 	case <-s.config.Clock.After(s.config.ForwardTimeout):
+		// scaletest hit this a *lot*
+		// perhaps we need to consider batching messages to run on the leader?
 		logger.Infof("timeout")
 		s.record(command.Operation, "timeout", start)
 		return lease.ErrTimeout

diff --git a/provider/ec2/provider.go b/provider/ec2/provider.go
@@ -36,6 +36,7 @@ func (environProvider) Version() int {
 
 // Open is specified in the EnvironProvider interface.
 func (p environProvider) Open(args environs.OpenParams) (environs.Environ, error) {
+	// This really shouldn't be INFO, it happens a lot.
 	logger.Infof("opening model %q", args.Config.Name())
 
 	e := new(environ)