-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use latest version of Bun and Deno for CI #3554
Conversation
build/build.ts
Outdated
@@ -58,7 +58,6 @@ const addExtension = (extension: string = '.js', fileExtension: string = '.ts'): | |||
}) | |||
|
|||
const commonOptions: BuildOptions = { | |||
watch: isWatch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because this line causes error Invalid option in build() call: "watch"
.
I couldn't find that Bun docs referring to the watch
option, and its only suggestion is to use --watch
option in command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get the error. How can I reproduce it? The watch
is for esbuild
, unrelated to the Bun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Probably it is a bug related Bun caching.
I will push the branch again without those changes. I guess the CI can catch the error.
Can you fix the CI error? |
6213af0
to
31fae48
Compare
setup-bun does not support |
31fae48
to
7560a70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 94.71% 89.74% -4.98%
==========================================
Files 158 158
Lines 9552 10080 +528
Branches 2825 2921 +96
==========================================
- Hits 9047 9046 -1
- Misses 505 1034 +529 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It passed! Thank you very much. I'll merge this now. |
* workflow: update setup-bun to v2 * workflow: use bun 1.1.33 * workflow: use deno 2.x
The author should do the following, if applicable
jsxImport bug in Bun appeared in 1.1.28, fixed in 1.1.33
Update
oven-sh/setup-bun
to v2Use Bun
1.1.x
Update
denoland/setup-deno
to v2Use
jsr:@david/[email protected]
Add tests
Run tests
bun run format:fix && bun run lint:fix
to format the codeAdd TSDoc/JSDoc to document the code