Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use latest version of Bun and Deno for CI #3554

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

fel1x-developer
Copy link
Contributor

@fel1x-developer fel1x-developer commented Oct 24, 2024

The author should do the following, if applicable

jsxImport bug in Bun appeared in 1.1.28, fixed in 1.1.33

  • Update oven-sh/setup-bun to v2

  • Use Bun 1.1.x

  • Update denoland/setup-deno to v2

  • Use jsr:@david/[email protected]

  • Add tests

  • Run tests

  • bun run format:fix && bun run lint:fix to format the code

  • Add TSDoc/JSDoc to document the code

build/build.ts Outdated
@@ -58,7 +58,6 @@ const addExtension = (extension: string = '.js', fileExtension: string = '.ts'):
})

const commonOptions: BuildOptions = {
watch: isWatch,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because this line causes error Invalid option in build() call: "watch".

I couldn't find that Bun docs referring to the watch option, and its only suggestion is to use --watch option in command.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fel1x-developer

I can't get the error. How can I reproduce it? The watch is for esbuild, unrelated to the Bun.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... Probably it is a bug related Bun caching.
I will push the branch again without those changes. I guess the CI can catch the error.

@yusukebe
Copy link
Member

@fel1x-developer

Can you fix the CI error?

@fel1x-developer
Copy link
Contributor Author

setup-bun does not support 1.x semantics. Using 1.1.x should work (according to their docs)

@yusukebe yusukebe changed the title Use latest version of Bun and Deno for CI ci: Use latest version of Bun and Deno for CI Nov 1, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (01277aa) to head (7560a70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
- Coverage   94.71%   89.74%   -4.98%     
==========================================
  Files         158      158              
  Lines        9552    10080     +528     
  Branches     2825     2921      +96     
==========================================
- Hits         9047     9046       -1     
- Misses        505     1034     +529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Nov 2, 2024

Hi @fel1x-developer

It passed! Thank you very much. I'll merge this now.

@yusukebe yusukebe merged commit 08e2912 into honojs:main Nov 2, 2024
16 checks passed
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Nov 11, 2024
* workflow: update setup-bun to v2

* workflow: use bun 1.1.33

* workflow: use deno 2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants