Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deno): remove duplicated app.get #3469

Merged
merged 1 commit into from
Sep 30, 2024
Merged

test(deno): remove duplicated app.get #3469

merged 1 commit into from
Sep 30, 2024

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Sep 30, 2024

image

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@exoego exoego marked this pull request as ready for review September 30, 2024 05:00
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (f1ec415) to head (d213c14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3469   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         155      155           
  Lines        9357     9357           
  Branches     2746     2767   +21     
=======================================
  Hits         8944     8944           
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@exoego

Ohh. Thank you very much!

@yusukebe yusukebe merged commit c0d782c into honojs:main Sep 30, 2024
16 checks passed
@exoego exoego deleted the dedup branch September 30, 2024 06:45
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants