Skip to content

Conversation

@ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Sep 3, 2024

Update libraries for writing tests in #3367. Also, this PR removes unnecessary code.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (3500404) to head (699513b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3375   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         152      152           
  Lines        9187     9187           
  Branches     2818     2749   -69     
=======================================
  Hits         8799     8799           
  Misses        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Sep 4, 2024

@ryuapp

We needed to do this. Thanks!

@yusukebe yusukebe merged commit f9a23a9 into honojs:main Sep 4, 2024
@ryuapp ryuapp deleted the use-jsr-library-for-testing branch September 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants