Skip to content

Refactor handling of discovered casts and device info #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2021
Merged

Refactor handling of discovered casts and device info #556

merged 5 commits into from
Nov 15, 2021

Conversation

emontnemery
Copy link
Collaborator

@emontnemery emontnemery commented Nov 10, 2021 •
edited
Loading

Breaking change

This is a breaking change if Chromecast objects are instantiated manually instead of via one of the discovery helpers

Refactor handling of discovered casts and device info

  • Simplify code paths by treating casts identified directly by a host:port pair same as auto discovered casts
  • Only poll casts via HTTP for device info once when creating Chromecast objects

See helper get_chromecast_from_host for how to instantiate a Chromecast object identified directly by a host:port pair

@emontnemery emontnemery merged commit a38e881 into master Nov 15, 2021
@emontnemery emontnemery deleted the refactor_host_port branch November 15, 2021 12:20
@interfect interfect mentioned this pull request Dec 10, 2021
Open
@emontnemery emontnemery mentioned this pull request Dec 23, 2021
Closed
@senorsnor senorsnor mentioned this pull request Dec 25, 2021
Closed
@sumnerevans sumnerevans mentioned this pull request Feb 10, 2022
Closed
@emontnemery emontnemery mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emontnemery @balloob