Replace template<class> with template<typename>#309
Conversation
|
@drupol Was there something else in the CR or can we merge this and close the old one? |
|
Hi! The changes look definitely good to me, but I would like to have someone else to review it as well... maybe @hmemcpy ? |
|
Gentle reminder for @hmemcpy |
|
Oh. Very sorry for my lack of being here... unfortunately I haven't touched C++ in... forever, so I really don't have much of an opinion here. I'd accept it, but I also think all those line-ending changes should be reverted, just to keep this PR focused. Another PR could be the housekeeping PR and trim all newlines and spaces... my 2c. |
|
I removed the last commit which is the only one that had any substantial housekeeping changes (at least by now since the original PR is quite old now), to keep the PR focused. Hope you think this is good enough! |
|
@hmemcpy I don't really know anything here, so I let you handle this. |
|
Well, I admit I asked Claude to go over the change and it completely agrees that it's compatible and valid :) Thanks very much for the contribution, @matssson, and sorry it took so long! |
Making a new PR for #260
Again I left the Licence file untouched.