Skip to content

Replace template<class> with template<typename>#309

Merged
hmemcpy merged 3 commits intohmemcpy:masterfrom
matssson:fix/typename
Jan 8, 2026
Merged

Replace template<class> with template<typename>#309
hmemcpy merged 3 commits intohmemcpy:masterfrom
matssson:fix/typename

Conversation

@matssson
Copy link
Contributor

Making a new PR for #260

Again I left the Licence file untouched.

@matssson
Copy link
Contributor Author

@drupol Was there something else in the CR or can we merge this and close the old one?

@drupol
Copy link
Collaborator

drupol commented Sep 29, 2023

Hi!

The changes look definitely good to me, but I would like to have someone else to review it as well... maybe @hmemcpy ?

@drupol
Copy link
Collaborator

drupol commented Jan 6, 2026

Gentle reminder for @hmemcpy

@hmemcpy
Copy link
Owner

hmemcpy commented Jan 6, 2026

Oh. Very sorry for my lack of being here... unfortunately I haven't touched C++ in... forever, so I really don't have much of an opinion here. I'd accept it, but I also think all those line-ending changes should be reverted, just to keep this PR focused.

Another PR could be the housekeeping PR and trim all newlines and spaces... my 2c.

@matssson
Copy link
Contributor Author

matssson commented Jan 6, 2026

I removed the last commit which is the only one that had any substantial housekeeping changes (at least by now since the original PR is quite old now), to keep the PR focused. Hope you think this is good enough!

@drupol
Copy link
Collaborator

drupol commented Jan 8, 2026

@hmemcpy I don't really know anything here, so I let you handle this.

@hmemcpy
Copy link
Owner

hmemcpy commented Jan 8, 2026

Well, I admit I asked Claude to go over the change and it completely agrees that it's compatible and valid :)
So I'm happy to accept it.
Merging!

Thanks very much for the contribution, @matssson, and sorry it took so long!

@hmemcpy hmemcpy merged commit 1b758c3 into hmemcpy:master Jan 8, 2026
12 checks passed
ktgw0316 added a commit to ktgw0316/milewski-ctfp-markdown that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants