-
Notifications
You must be signed in to change notification settings - Fork 24
Document Identity System changes for Web Chat #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
+ This error event can be subscribed to for handling runtime errors programmatically
6784a37 to
27a1087
Compare
+ This describes all the errors, their reasons, as well as the details that can occur via the onWebChatRuntimeError event. + The tables are not "formatted" because MDX does not compile correctly due to whitespaces.
+ This is to let the devs know user session expiry conditions + Ref: https://helpshift.atlassian.net/browse/HS-18282
+ The identity token schema is necessary for developers to understand what the backend endpoint should return and to reduce back and forth between KB articles and Dev Docs
hs-umang
approved these changes
Nov 19, 2024
d3c64f3 to
fdb700b
Compare
fdb700b to
a8737dd
Compare
a8737dd to
1555047
Compare
hs-umang
reviewed
Nov 29, 2024
1555047 to
eb305c2
Compare
eb305c2 to
474580f
Compare
+ Instead of documenting the profile update APIs separately,
we are centralizing them on a new page
+ We're linking the entire page on the APIs page to ensure
consistency and discoverability
+ Also addressed these review comments:
+ Mentioned that the feature is in closed beta
+ Changed "support" to "Customer Success"
+ Moved "addUserIdentities" API documentation right after
the login information
+ Removed the TODO
+ Changed Users title to add "Legacy" for clear bifurcation
474580f to
a96bffb
Compare
51031b4 to
992317f
Compare
KrishnaMB-PM
approved these changes
Nov 29, 2024
Collaborator
KrishnaMB-PM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go to production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents all the JS APIs, events, and other details required for integrating the new Identity system.