Honor include_hidden on inline boolean inputs
#1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
nested-style boolean inputs, it's possible to opt-out of the hidden inputgeneration by passing the
include_hidden: falseoption.However, for
inlineinputs, this still generates the hidden field, causingan inconsistency between the two boolean styles, and a whole lot of late night confusion.
A workaround has been proposed in a comment from 2016,
which consists in passing
include_hiddenin theinput_html. I think this isnot ideal, as it causes inconsitencies between the APIs of the boolean styles.
This PR makes the inline checkboxes honor the
include_hiddenstyles, making their API consistent.