update bootstrap v4.1 generator template #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple form now 💜 bootstrap 4.1 The bootstrap generator is extracted from: heartcombo/simple_form-bootstrap#56 * supported form wrapper all covered by *tests* * vertical form * horizontal form * inline form * custom fields form * input groups form * floating labels form :link: heartcombo/simple_form-bootstrap#56 🔗 heartcombo#1561 Resolves heartcombo#1337
feliperenan
reviewed
Apr 10, 2018
| # add validation classes to `input_field` | ||
| config.input_field_error_class = 'is-invalid' | ||
| config.input_field_valid_class = 'is-valid' | ||
|
|
There was a problem hiding this comment.
Duplicate blank line ✂️
There was a problem hiding this comment.
I see it in other places, so I think it was intentional. Just one line for me it's ok, feel free to make this change 😄
There was a problem hiding this comment.
I've added two blank lines before each form block (vertical, horizontal, inline, custom, group and floating) for better readability or scan-ability.
feliperenan
approved these changes
Apr 10, 2018
| # Use this setup block to configure all options available in SimpleForm. | ||
| SimpleForm.setup do |config| | ||
| # Default class for buttons | ||
| config.button_class = 'btn' |
There was a problem hiding this comment.
Should this be 'btn btn-primary'?
There was a problem hiding this comment.
Answered here: heartcombo/simple_form-bootstrap#56 (comment)
This was referenced May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple form now 💜 bootstrap 4.1
📺 Demo preview
The bootstrap generator is extracted from:
heartcombo/simple_form-bootstrap#56
🔗 heartcombo/simple_form-bootstrap#56
📌 Bootstrap generator template is maintained by the community around simple_form-bootstrap
⛏ All future development, tests, and organization should happen there.