This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Avoid reading serviceaccount-token in DNS Mode #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-mounting the serviceaccount-token is sometimes disabled to avoid giving applications access to the kubernetes api when they don't need it. The current method of constructing an instance of `KubernetesConfig` will try to read the information from the mounted serviceaccount token even if a Service DNS is specified. This will fail in environments described earlier. The information gathered from reading the serviceaccount-token fields is only relevant for API mode. This commit will avoid reading the token if DNS Lookup is configured. This fixes hazelcast#284
Contributor
|
|
hasancelik
approved these changes
Feb 4, 2021
hasancelik
left a comment
hasancelik
left a comment
There was a problem hiding this comment.
Thanks for your contribution @fr1zle 👍
Actually, we need more clearer separation between API and DNS mode while creating a config and discovery strategy but it is another PR's topic :)
LGTM ✅
SeriyBg
approved these changes
Feb 4, 2021
Contributor
Author
|
Thanks, if I find some time I will take a look into a clean separation of the configurations. Now we will not have to configure dummy cacerts and tokens at least ;) |
|
It would be great, ping me if you need any help about internals 👍 yes, it is a good starting point :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-mounting the serviceaccount-token is sometimes disabled to avoid giving applications
access to the kubernetes api when they don't need it. The current method of constructing
an instance of
KubernetesConfigwill try to read the information from the mounted serviceaccounttoken even if a Service DNS is specified. This will fail in environments described earlier.
The information gathered from reading the serviceaccount-token fields is only relevant
for API mode. This commit will avoid reading the token if DNS Lookup is configured.
This fixes #284