This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fix Auto Detection when Kubernetes Master is not available #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrinot
reviewed
Nov 2, 2020
| return new File("/var/run/secrets/kubernetes.io/serviceaccount/token").exists(); | ||
| } | ||
|
|
||
| private boolean defaultKubernetesMasterReachable() { | ||
| try { | ||
| InetAddress.getByName("kubernetes.default.svc"); |
There was a problem hiding this comment.
actually, perhaps it's not all that relevant. it's guarded by the fs token check.
So if someone is running a k8s cluster with slow DNS then it's OK if this is slow too.
There was a problem hiding this comment.
Yeah, it's only for corner cases, like you're running in Kubernetes, but kube-dns is not configured.
jerrinot
approved these changes
Nov 2, 2020
jerrinot
reviewed
Nov 2, 2020
| @@ -34,6 +37,7 @@ | |||
| */ | |||
| public class HazelcastKubernetesDiscoveryStrategyFactory | |||
| implements DiscoveryStrategyFactory { | |||
| private static final ILogger LOGGER = Logger.getLogger(HazelcastKubernetesDiscoveryStrategyFactory.class); | |||
There was a problem hiding this comment.
nitpick: you could move this to the catch branch. as in most cases it wont be needed. and a static logger initialization has some disadvantages so we should avoid it unless necessary.
hasancelik
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #269