This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fix rethrowing exception #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to use ExceptionUtils.rethrow from Hazelcast core, however its logic has changed and now it always throws HazelcastException.
pivovarit
reviewed
Jul 24, 2020
| } | ||
| } | ||
|
|
||
| private static RuntimeException rethrowUnchecked(Exception e) { |
Contributor
There was a problem hiding this comment.
Well, it doesn't really rethrow anything, so it might be worth adjusting the name :)
unchecked() would work just fine
Author
There was a problem hiding this comment.
👍
Updated. I also updated the same for hazelcast-aws.
pivovarit
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to use ExceptionUtils.rethrow from Hazelcast core, however its logic has changed and now it always throws HazelcastException.