This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fix issue that was preventing to use service-dns for Hazelcast 3.x #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elm chart As the property service.name is defined by the default in the Hazelcast chart and it cannot be used in conjunction with service-dns, it's needed to use an empty value for service.name, what is not allowed in the current version. This same fix was already done in the version 2.x, but it still was not fixed in the version 1.5.x, which prevents to use service-dns to connect with the version 3.x of Hazelcast.
Contributor
|
|
Contributor
|
Can one of the admins verify this patch? |
Author
|
verify |
hasancelik
approved these changes
Jul 17, 2020
hasancelik
left a comment
hasancelik
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution @diegoep 👍
leszko
approved these changes
Jul 17, 2020
Author
|
Is there any scheduled date for publishing the version 1.5.4 with this fix? |
|
We'll publish it this week. I'll let you know when it's released. |
Author
Ok. Thank you! |
|
FYI: hazelcast-kubernetes 1.5.4 and 2.0.2 are released. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed via helm chart, the property service.name is defined by the default in the Hazelcast chart and it cannot be used in conjunction with service-dns, it's needed to use an empty value for service.name, what is not allowed in the current version. This same fix was already done in the version 2.x, but it still was not fixed in the version 1.5.x, which prevents to use service-dns to connect with the version 3.x of Hazelcast.