Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Add missing instruction for Windows Image user #4802

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

TsuyoshiUshio
Copy link
Contributor

@TsuyoshiUshio TsuyoshiUshio commented Apr 19, 2017

When we build a Windows based VHD image, we need to specify object_id.
However, object_id is very ambiguous and not mentioned on this document.
I add some explanation and how to get it.

closes #4803

Related source code

NewStepValidateTemplate(azureClient, ui, b.config, GetKeyVaultDeployment),

ObjectId: &template.TemplateParameter{Value: config.ObjectID},

When we build a Windows based VHD image, we need to specify object_id.
However, object_id is very ambigous and not mentioned on this document.
I add some explanation and how to get it.
@TsuyoshiUshio TsuyoshiUshio changed the title Add missing instruction for Windows Image user Add missing instruction for Windows Image user on Azure Apr 19, 2017
@rickard-von-essen rickard-von-essen changed the title Add missing instruction for Windows Image user on Azure azure: Add missing instruction for Windows Image user Apr 19, 2017
@boumenot
Copy link
Collaborator

LGTM.

@mwhooker
Copy link
Contributor

thanks!

@mwhooker mwhooker merged commit b42c4a0 into hashicorp:master Apr 19, 2017
mwhooker added a commit that referenced this pull request Apr 19, 2017
azure: Add missing instruction for Windows Image user
@mwhooker
Copy link
Contributor

cherry-picked to stable-website

@TsuyoshiUshio
Copy link
Contributor Author

Thank you, guys! :) I love Packer!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing instruction for Azure Setup document for object_id
4 participants