-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet: create batch transactions with any combination of covenants #686
Conversation
< $ hsw-rpc sendbatch '[["REDEEM", "name1"],["REDEEM" ,"name1"],["REDEEM", "name1"],["REDEEM","name1"]]' > throws error "no reveals to redeem" while < $ hsw-rpc sendredeem > works fine and redeems all the lost bids. |
0e4482e
to
5e33184
Compare
@DIPMR you shouldn't need to call You could try if you were trying to redeem multiple different names and got this error, could you let me know? |
@DIPMR I was able to redeem in batches using this series of commands on regtest:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me !
Creates batching functions in the wallet and exposes two new RPC calls:
sendbatch
andcreatebatch
. The argument is an array of "actions". Actions are an array that starts with a string indicating the action type (usually a covenant but could also be meta-covenant type likeCANCEL
) followed by the arguments expected by the correspondingmake___()
function.Examples:
TODO: