Skip to content

Commit

Permalink
fix weird error in integration tests
Browse files Browse the repository at this point in the history
somehow the variable "$i" gets overwritten in integration-testing/multi-nodejs-test/test.sh:20, which is why we now rename it to a more meaningful variable
  • Loading branch information
nknapp committed Feb 15, 2021
1 parent b6d3de7 commit eb860c0
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions integration-testing/multi-nodejs-test/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,20 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
# However, the built distribution should work with older NodeJS versions as well.
# This test is simple by design. It merely ensures, that calling Handlebars does not fail with old versions.
# It does (almost) not test for correctness, because that is already done in the mocha-tests.
# And it does not use any NodeJS based testing framwork to make this part independent of the Node version.
# And it does not use any NodeJS based testing framework to make this part independent of the Node version.

unset npm_config_prefix

echo "Handlebars should be able to run in various versions of NodeJS"
for i in 0.10 0.12 4 5 6 7 8 9 10 11 12 13 ; do
for node_version_to_test in 0.10 0.12 4 5 6 7 8 9 10 11 12 13 14 15; do

rm target node_modules package-lock.json -rf
mkdir target
nvm install "$i"
nvm exec "$i" npm install
nvm exec "$i" npm run test
nvm exec "$i" npm run test-precompile

nvm install "$node_version_to_test"
nvm exec "$node_version_to_test" npm install
nvm exec "$node_version_to_test" npm run test
nvm exec "$node_version_to_test" npm run test-precompile

echo Success
done

0 comments on commit eb860c0

Please sign in to comment.