Add AWS Secrets Manager FS #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
documentation
hairyhenderson
force-pushed
the
awssmfs-6
branch
5 times, most recently
from
0b581e0 to
aa915f1
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
awssmfs-6
branch
from
aa915f1 to
a4b04ed
Compare
Owner
Author
|
At some point I'll also add an integration test based on Localstack, but this bug prevents that: localstack/localstack#4820. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Support for AWS SM filesystem, with the
aws+smURL scheme.Because this is effectively a flat namespace, I had to infer directory structure (using
/as path separator in the secret name, as seems to be the recommendation in the AWS docs). A side-effect is that you can either get a filesystem rooted on secrets that start with/, or not. That means if a SM store has two secrets/fooandbar, you can't have a filesystem where both will be accessible. I think in practice this may not be a big deal, as I expect Secrets Manager users will likely use either a/-rooted convention, or not, but not both.Signed-off-by: Dave Henderson [email protected]