remove all logrus calls. Add ctx #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pxp928 <[email protected]>
mihaimaruseac
approved these changes
Nov 15, 2022
lumjjb
reviewed
Nov 16, 2022
| @@ -297,28 +310,28 @@ func TestDelete(t *testing.T) { | |||
| } | |||
|
|
|||
| type mockKeyProvider struct { | |||
| collector map[string]Key | |||
| collector map[string]*Key | |||
There was a problem hiding this comment.
hmm quick question on the change here? is this related to ctx change or just a drive by?
There was a problem hiding this comment.
So as I was adding in the context, the unit test started to fail. Some keys were being overwritten before the test could complete. That was the reason for the changes. Added issue #232 to capture this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all traces of Logrus that is not being used. Also, pass context to get logger from context.
Fixed unit test bug in key_test.go
Edit:
Fixes #232
Signed-off-by: pxp928 [email protected]