Consume results of write-only transactions #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's not strictly necessary, since the Neo4j server will execute the transaction queries just before commit at latest, consuming results makes sure the queries are run right when the client starts pulling results. Another advantage is that some query errors will surface when you consume results and not when you commit.
lumjjb
approved these changes
Oct 21, 2022
mihaimaruseac
approved these changes
Oct 21, 2022
lumjjb
pushed a commit
that referenced
this pull request
Oct 21, 2022
While it's not strictly necessary, since the Neo4j server will execute the transaction queries just before commit at latest, consuming results makes sure the queries are run right when the client starts pulling results. Another advantage is that some query errors will surface when you consume results and not when you commit.
|
hi @fbiville noticed that there was an issue with the sign off message (DCO), with your permission can we add the DCO sign off line on your behalf? |
|
@lumjjb I somehow completely missed your message, apologies. No problem to add the sign off as you've probably already done by now |
mrizzi
pushed a commit
to mrizzi/guac
that referenced
this pull request
Nov 25, 2024
…ec#176) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's not strictly necessary, since the Neo4j server will execute the transaction queries just before commit at latest, consuming results makes sure the queries are run right when the client starts pulling results.
Another advantage is that some query errors will surface when you consume results and not when you commit.