Make ic a function instead of an instance to improve distinction and intuitiveness
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent out __call__ of IceCreamDebugger
YunfangHou
changed the title
ic a function instead of an instance to improve distinctionic a function instead of an instance to improve distinction and intuitiveness
|
ping @gruns 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #192
ic_aux, which is basically as same as the function__call__, but adding one moref_backaftercallFrame = inspect.currentframe().f_back, becauseic_auxis invoked one more level of function.ic, which initializes an instance ofIceCreamDebuggerand invokes theic_auxfunction of the instance.__call__function inIceCreamDebugger.The effect is shown in the image below. The
icis now highlighted in the color of a function, with higher distinction and intuitiveness in user's IDE.