Prevent clobbering rules and custom rules #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
gigxz
reviewed
Aug 27, 2024
| @@ -41,6 +41,9 @@ class Forms::FormItem < Types::BaseObject | |||
| field :autofill_values, [Forms::AutofillValue], 'Value(s) to autofill based on conditional logic', null: true | |||
| field :service_detail_type, Forms::Enums::ServiceDetailType, 'Whether to apply this field to all clients or a single client when bulk creating', null: true, deprecation_reason: 'from old bulk services implementation, no longer supported' | |||
|
|
|||
| field :rule, Forms::FormItemRule, null: true | |||
| field :custom_rule, Forms::FormItemRule, null: true | |||
There was a problem hiding this comment.
decision: resolve these as json fields, revisit type when we build a frontend for them
gigxz
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please squash merge this PR
Description
GH issue https://github.com/open-path/Green-River/issues/6555
I'd like to discuss this more and maybe pair to come up with a better solution, but also want to be transparent that I'm nearing the estimate for the ticket (2.5 of 3h).
My head is spinning a bit from this years-old but still outstanding GraphQL discussion thread on supporting scalar union types: graphql/graphql-spec#215
Type of change
Checklist before requesting review