Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prediction task subsection #23

Merged
merged 13 commits into from
Aug 14, 2019
Merged

Add prediction task subsection #23

merged 13 commits into from
Aug 14, 2019

Conversation

zietzm
Copy link
Collaborator

@zietzm zietzm commented Aug 8, 2019

No description provided.

@zietzm zietzm added the Methods PR references the Methods section label Aug 8, 2019
@zietzm zietzm requested review from cgreene and dhimmel August 8, 2019 20:21
cgreene
cgreene requested changes Aug 13, 2019
View reviewed changes
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few points that should probably get another look. That long sentence is important but unwieldy - a dangerous combination! Is there a way to split it into a couple simpler sentences?

content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
content/02.body.md Outdated Show resolved Hide resolved
cgreene
cgreene approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh - really like the splitting of those sentences 👍

@zietzm zietzm merged commit a501622 into greenelab:master Aug 14, 2019
@zietzm zietzm deleted the methods-5 branch August 14, 2019 12:56
zietzm added a commit that referenced this pull request Aug 14, 2019
@zietzm
Add prediction task subsection (#23)
d30e6f3 
This build is based on
a501622.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/greenelab/xswap-manuscript/builds/123220016
https://travis-ci.com/greenelab/xswap-manuscript/jobs/225187547

[ci skip]

The full commit message that triggered this build is copied below:

Add prediction task subsection (#23)

Merges #23
zietzm added a commit that referenced this pull request Aug 14, 2019
@zietzm
Add prediction task subsection (#23)
20f7d8b 
This build is based on
a501622.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/greenelab/xswap-manuscript/builds/123220016
https://travis-ci.com/greenelab/xswap-manuscript/jobs/225187547

[ci skip]

The full commit message that triggered this build is copied below:

Add prediction task subsection (#23)

Merges #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgreene cgreene cgreene approved these changes

@dhimmel dhimmel Awaiting requested review from dhimmel

Assignees
No one assigned
Labels
Methods PR references the Methods section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zietzm @cgreene