Changes for modern ios and GraphHopper 1.0 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle dependencies
Member
|
There is now a branch with the required changes: https://github.com/graphhopper/graphhopper/commits/ios_compatibility Do you need anything more from me or should I merge :) ? |
oflebbe
force-pushed
the
master
branch
2 times, most recently
from
da589ae to
da14061
Compare
karussell
changed the title
Member
|
@oflebbe if you like we can have this easier merged now that we do no longer require a CLA: graphhopper/graphhopper#2279 (the agreement that this contribution stands under the Apache license 2.0 still holds but is implicit due to the project license) Let me know if I can be of any help to get this merged. |
Contributor
Author
|
Please wait a bit longer ... there is progress |
|
@oflebbe Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just depends on github.com/oflebbe/graphhopper branch ios_compat_new
Would it be possible as a workaround merge
github.com/oflebbe/graphhopper branch ios_compat_new to
github.com/graphhopper/graphhopper branch ios_compat_new (or similary named)
first?
Since the branch ios-compat is way too old to be resynced to master.
Open points w/o priorities:
However the patch is included gives value alone, I would propose to handle the open points in subsequent PR's.