Remove the name property from vehicle parsers #2931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It seems it is used for migration purposes like this: #2929 (?) but I also think this is not necessary. E.g. for hike we did this before but now only use the foot encoded values in the custom model and add some "hike" statements. |
Member
Author
|
Ok but since we are removing vehicles altogether we don't need customizable names for vehicles, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is leftover code of the old flag encoder approach and I don't think it has a real use case. The only thing I could think of that could be useful is using multiple roads vehicles with different transportation modes but this doesn't even work currently, because we ignore the 'name' field here