Skip to content

Conversation

@karussell
Copy link
Member

@karussell karussell commented Dec 9, 2023

This introduces a compound boolean EncodedValue bus_access including the oneway handling but without road_class handling ("bus" in the sense of a psv = public service vehicle).

A separate bus_oneway_access is unnecessary as the only known use case atm (for ambulances) would be to allow opposite travel of oneways which could be achieved with backward_bus_access instead.

This is a replacement of #2710. The new ModeAccessParser can be used with any of the values in the TransportationMode enum e.g. also motorcycle. The idea is that is can be (later) used as a replacement for CarAccessParser too. (Furthermore the oneway code in CarAccessParser should be simplified)

Unfortunately the enum in #2710 cannot handle oneway roads properly. For #2710 there is a problem: if bus=yes on oneway roads and motor_vehicle=no then the bus profile would allow access in the opposite direction of the oneway road too. See this route as an example. (We could make the enum direction-dependent to handle oneway roads. Then we could also consider tags like "bus=designated" in the profile to prefer these ways. But this would be too confusing as the enum would no longer represent the OSM data and bus==YES in the custom_model would not necessarily mean bus=yes in OSM.)

The usage is outlined in the bus.json.

@karussell karussell changed the title bus profile bus access Dec 9, 2023
@tolot27
Copy link

tolot27 commented Jan 20, 2024

Will this PR also result in a new transportation profile at GraphHopper Maps? Currently, I'm using custom profiles but they do not work for distances further than 500 km apart.

@karussell
Copy link
Member Author

Will this PR also result in a new transportation profile at GraphHopper Maps

no

@karussell karussell added this to the 9.0 milestone Feb 8, 2024
@karussell karussell merged commit 2d2b568 into master Feb 8, 2024
@karussell karussell deleted the vehicle_enums branch February 8, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants