Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conditional access restrictions configurable #2863

Merged
merged 42 commits into from
Mar 6, 2024
Merged

Conversation

karussell
Copy link
Member

@karussell karussell commented Aug 14, 2023

This PR removes the conditional blocking access from the vehicle parsers. I.e. after this change you need to add e.g. car_road_access_conditional == NO into a custom model to still consider temporary restrictions due to constructions.

This PR also:

I added some more path details to the Measurement so the response time is expected to be a bit slower for this single test.

Here is an OSM way with vehicle:conditional=no @ (Nov 1-Mar 31) for testing purposes. GH Maps link.

On GraphHopper Maps we now show a route hint for outdoor profiles and in the details widget the exact values are shown:

image

@karussell karussell temporarily deployed to benchmarks August 18, 2023 17:53 — with GitHub Actions Inactive
@karussell karussell temporarily deployed to benchmarks August 18, 2023 20:06 — with GitHub Actions Inactive
@karussell karussell marked this pull request as ready for review August 22, 2023 18:43
@karussell karussell changed the title Make conditional access configurable for car Make conditional access restrictions configurable Aug 22, 2023
@mihai-craciun-ursu
Copy link

Hello, is there any timeline when this will be released? I supposed this will be included in 9.0, I just hoped to know when will 9.0 be available.

@karussell
Copy link
Member Author

karussell commented Feb 26, 2024

There is no timeline for this PR and it might or might not included in 9.0 but you can always try this development branch out and give feedback :)

(However, 9.0 will be released in March or April.)

@karussell karussell added this to the 9.0 milestone Mar 6, 2024
@karussell karussell merged commit 74ba675 into master Mar 6, 2024
4 checks passed
@karussell karussell deleted the conditional_access branch March 6, 2024 11:25
karussell added a commit that referenced this pull request Mar 7, 2024
@hungerburg
Copy link

I do not see the conditional here, all the way "Type: null" - https://graphhopper.com/maps/?point=47.307968%2C11.519214&point=47.338586%2C11.507562&profile=hike&layer=TF+Outdoors - It routes over a via ferrata that is closed in winter. C.f. #1326

@karussell
Copy link
Member Author

karussell commented Apr 2, 2024

We need to make this information better accessible in the UI: graphhopper/graphhopper-maps#378 and maybe provide a way to easily exclude them with foot_access_conditional == NO.

@karussell
Copy link
Member Author

karussell commented Apr 2, 2024

It is now shown (refresh necessary). Multiple clicks on the icon will loop through all the conditional restrictions.

image

The next step would be to add a button to exclude these obstacles but this is not that simple but will try to find a way.

@hungerburg
Copy link

I read "refresh necessary" and did not see a change. Then I read "click on the icon" and now I see. It would have never appeared to me that the icons can be clicked.

From A user PoV I would be fine with being told, a bit more immediately visible than now - perhaps the section pre-clicked? I would not expect a magic button to solve the issue. Some routers offer alternatives in all cases, maybe suggest to tune by placing a via close by - What do I know?

PS - In this very case: I think, graphhopper should just drop any "highway=via_ferrata" when ingesting OSM data. Much as OSM-Carto does or thunderforest does. These highways are of no use neither for the foot not the hike profile.

@karussell
Copy link
Member Author

karussell commented Apr 2, 2024

From A user PoV I would be fine with being told, a bit more immediately visible than now - perhaps the section pre-clicked?

Will think about how to improve this. I would prefer to avoid "pre-clicked" due to the "clutter" it might add.

These highways are of no use neither for the foot not the hike profile.

Ok, will skip via_ferrata and then also close #1326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ignoring seasonal roads
3 participants