Add new --auto-approve=if-no-changes option
#754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #743 Closes #693 It replaces the `--dangerous-auto-approve` option. It has three values: `always`, `never` and `if-no-changes` In this PR, I also create a common structure for args that are shared between `prune`, `delete` and `apply` Doing so, I found two bugs: - Removed the `--validate` option on `delete`, it wasn't used - Wired in `--dry-run` to the `prune` command, it was exposed but didn't make it to kubectl
julienduchesne
changed the title
--auto-approve option--auto-approve=if-no-changes option
jjo
approved these changes
Sep 12, 2022
| @@ -29,6 +29,28 @@ func validateDryRun(dryRunStr string) error { | |||
| return fmt.Errorf(`--dry-run must be either: "", "none", "server" or "client"`) | |||
| } | |||
|
|
|||
| func validateAutoApprove(autoApproveDeprecated bool, autoApproveString string) (tanka.AutoApproveSetting, error) { | |||
There was a problem hiding this comment.
Would using at switch-case construct here help with streamlining the code?
|
would love to see this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #743
Closes #693
It replaces the
--dangerous-auto-approveoption. It has three values:always,neverandif-no-changesIn this PR, I also create a common structure for args that are shared between
prune,deleteandapplyDoing so, I found two bugs:--validateoption ondelete, it wasn't used--dry-runto theprunecommand, it was exposed but didn't make it to kubectl