Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): improve spec.json parse error #71

Merged
merged 1 commit into from
Sep 13, 2019
Merged

fix(cli): improve spec.json parse error #71

merged 1 commit into from
Sep 13, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Sep 13, 2019

Adds another error context to make it clear to the user that the error relates
to spec.json and not the jsonnet.

Fixes #70

@sh0rez
fix(cli): improve spec.json parse error
16ba7bf 
Adds another error context to make it clear to the user that the error relates
to `spec.json` and not the jsonnet.
@sh0rez sh0rez added kind/bug Something isn't working component/cli Command Line Interface labels Sep 13, 2019
@sh0rez sh0rez self-assigned this Sep 13, 2019
cyriltovena
cyriltovena approved these changes Sep 13, 2019
View reviewed changes
Copy link

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

malcolmholmes
malcolmholmes approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, so fast!

@sh0rez sh0rez merged commit 5694855 into master Sep 13, 2019
@sh0rez sh0rez deleted the spec-err branch September 13, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmholmes malcolmholmes malcolmholmes approved these changes

@cyriltovena cyriltovena cyriltovena approved these changes

@gouthamve gouthamve Awaiting requested review from gouthamve

@slim-bean slim-bean Awaiting requested review from slim-bean

Assignees

@sh0rez sh0rez

Labels
component/cli Command Line Interface kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insufficient context when failing to parse spec.json
3 participants
@sh0rez @cyriltovena @malcolmholmes