Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Charts: Add pruning option #707

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Helm Charts: Add pruning option #707

merged 2 commits into from
Jun 1, 2022

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Jun 1, 2022 •
edited
Loading

Adds a --prune option to the vendor command
When set to true, files and directories that shouldn't be there will be deleted after vendoring
This allows the tk tool charts vendor --prune command to be run in CI to ensure that charts are up-to-date

@julienduchesne julienduchesne requested review from Duologic, sh0rez and a team June 1, 2022 12:39
Duologic
Duologic approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting close to package management, jsonnet-bundler for Helm... 😇

@julienduchesne
Copy link
Member Author

julienduchesne commented Jun 1, 2022 •
edited
Loading

This is getting close to package management, jsonnet-bundler for Helm... 😇

I just realized, I made this a field in chartfile.yaml but it would be better as an option of the vendor command (tk tool charts vendor --prune), I think. Any opinions?

@julienduchesne
Helm Charts: Add pruning option
750ca25 
Adds a `prune: (bool)` field to the chartfile.yaml
When set to true, files and directories that shouldn't be there will be deleted after vendoring
This allows the `tk tool charts vendor` command to be run in CI to ensure that charts are up-to-date
@julienduchesne
Make prune an option of the vendor command
43bc29f
@julienduchesne julienduchesne force-pushed the julienduchesne/charts-prune branch from dae9902 to 43bc29f Compare June 1, 2022 14:46
@julienduchesne julienduchesne requested a review from Duologic June 1, 2022 14:47
@julienduchesne
Copy link
Member Author

Re-requesting review because I changed it to be a --prune option on the vendor command

@julienduchesne julienduchesne merged commit 13a191a into main Jun 1, 2022
@julienduchesne julienduchesne deleted the julienduchesne/charts-prune branch June 1, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duologic Duologic Duologic approved these changes

@sh0rez sh0rez Awaiting requested review from sh0rez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienduchesne @Duologic