Support a diff-strategy of "none" for "tk apply" to suppress diffing. #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to get a review of this? It would be a useful enhancement for developers dealing with similar issues as myself. |
|
Would be great to have this in, I'm doing the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a diff strategy of
nonefortk applythat completely suppresses diffing before the apply operation.The reason I'm submitting this is that I'm using Tanka to create a very large set of Kubernetes resources and it takes 5 to 10 minutes to perform the diff operation before getting to the apply stage. Since I often use a
tk diffmyself first, before thetk apply, I don't need the diff that's part ofapplyin some cases. Also, when our automated job runs to do atk apply, it uses the--dangerous-auto-approveoption, with no human present observe the diff output. The 5 to 10 minute delay in this step of the automation makes the automation job run longer than desired, delaying the deployment of the things that come after this step.I would like to change some documentation to describe the
noneoption totk apply, but I don't see any good place to put that. Any suggestion would be welcome.