Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon binary #685

Merged
merged 5 commits into from
Mar 25, 2022
Merged

Conversation

BeyondEvil
Copy link
Contributor

Adds support for Apple Silicon aka arm64.

@BeyondEvil BeyondEvil force-pushed the jim/support-apple-silicon branch from 41f4f8d to f68e92a Compare March 22, 2022 12:50
@BeyondEvil
Copy link
Contributor Author

I probably did an oopsie somehow: Build is blocked, please, contact repo admin in order to proceed

@Duologic
Copy link
Member

The Drone build config needs to be signed by someone at Grafana, I'll approve the build and look for the singing.

@BeyondEvil
Copy link
Contributor Author

Not sure what the correct path for the error in build is. Locally go install works for me, but in drone it seems it wants go get. 🤔

@BeyondEvil
Copy link
Contributor Author

I think I've solved it @Duologic , but you need to approve the build.

Also, GitHub seems to be experiencing some issues.

@Duologic
Copy link
Member

Looks like it worked!

@Duologic
Copy link
Member

Going to force merge as the failing bits are unrelated to the change and probably caused by Github being unstable.

@BeyondEvil
Copy link
Contributor Author

Looks like it worked!

Nice!

Is it possible to rerun the failed ones?

Are my changes sufficient to also actually publish the arm64 under the release?

@Duologic
Copy link
Member

Hmm, now I'm thinking we should consider an Apple Silicon docker image too, but I don't know how that would work (it also has several other binaries that need to be taken into account.

@BeyondEvil
Copy link
Contributor Author

Hmm, now I'm thinking we should consider an Apple Silicon docker image too, but I don't know how that would work (it also has several other binaries that need to be taken into account.

Good point. 🤔

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've signed the Drone yaml file

@BeyondEvil
Copy link
Contributor Author

Anything more I can do?

@Duologic
Copy link
Member

We can do the docker image in a separate PR.

@Duologic Duologic merged commit 761db80 into grafana:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants