-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apple Silicon binary #685
Conversation
41f4f8d
to
f68e92a
Compare
I probably did an oopsie somehow: |
The Drone build config needs to be signed by someone at Grafana, I'll approve the build and look for the singing. |
Not sure what the correct path for the error in |
I think I've solved it @Duologic , but you need to approve the build. Also, GitHub seems to be experiencing some issues. |
Looks like it worked! |
Going to force merge as the failing bits are unrelated to the change and probably caused by Github being unstable. |
Nice! Is it possible to rerun the failed ones? Are my changes sufficient to also actually publish the arm64 under the release? |
Hmm, now I'm thinking we should consider an Apple Silicon docker image too, but I don't know how that would work (it also has several other binaries that need to be taken into account. |
Good point. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've signed the Drone yaml file
Anything more I can do? |
We can do the docker image in a separate PR. |
Adds support for Apple Silicon aka arm64.