Fix target must be a non-nil pointer
#684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
requested changes
Mar 30, 2022
There was a problem hiding this comment.
from errors.Is:
// An error is considered to match a target if it is equal to that target or if
// it implements a method Is(error) bool such that Is(target) returns true.
to me that reads as if it compares using ==, which would be exact equivalence, not type equivalence. however, the error is very unlikely to be an empty ErrNamespaceNotFound struct, so this would not catch it.
that being said, if target must be a non-nil pointer, wouldn't it suffice to change it to &client.ErrNamespaceNotFound{}?
With an API server for which I'm not authentified with correctly, `tanka` would panic with `target must be a non-nil pointer` because of a call to `errors.As`. We cannot use `errors.Is` here because there is multiple instance of the error possible and `errors.Is` use strict equality and not type's equality. So the fix is simply to use a pointer receiver instead.
This was happening trying to show the diff because it seems I'm not configured correctly (I was logged in using the wrong credentials).
```
WARNING: version difference between client (1.23) and server (1.20) exceeds the supported minor version skew of +/-1
Error from server (Forbidden): namespaces "default" is forbidden: User "<email>" cannot get resource "namespaces" in API group "" in the namespace "default": requires one of ["container.namespaces.get"] permission(s).
panic: errors: target must be a non-nil pointer
```
```
panic: errors: target must be a non-nil pointer
goroutine 1 [running]:
errors.As({0x10130dae8, 0x140000b2000}, {0x1012c0800, 0x101794360})
/usr/local/go/src/errors/wrap.go:85 +0x3e0
github.com/pkg/errors.As(...)
/Users/maoueh/go/pkg/mod/github.com/pkg/[email protected]/go113.go:31
github.com/grafana/tanka/pkg/kubernetes.(*Kubernetes).Diff(0x140004961a0, {0x140003f39d0, 0x2, 0x2}, {0x0?, 0x0?, {0x0?, 0x0?}})
/Users/maoueh/work/github/grafana_tanka/pkg/kubernetes/diff.go:31 +0x4b8
github.com/grafana/tanka/pkg/tanka.Diff({0x16effebc0?, 0x140001edc58?}, {{{0x0, 0x140003227b0, 0x140003227e0, {0x0, 0x0, 0x0}, {0x0, 0x0}, ...}, ...}, ...})
/Users/maoueh/work/github/grafana_tanka/pkg/tanka/workflow.go:122 +0xdc
main.diffCmd.func1(0x140001c4800?, {0x140002f8390, 0x1, 0x1?})
/Users/maoueh/work/github/grafana_tanka/cmd/tk/workflow.go:158 +0x19c
github.com/go-clix/cli.(*Command).execute(0x140002afea0, {0x140002f8370, 0x1, 0x1})
/Users/maoueh/go/pkg/mod/github.com/go-clix/[email protected]/command.go:118 +0x2b4
github.com/go-clix/cli.(*Command).Execute(0x140002af0e0)
/Users/maoueh/go/pkg/mod/github.com/go-clix/[email protected]/command.go:76 +0xd4
main.main()
/Users/maoueh/work/github/grafana_tanka/cmd/tk/main.go:58 +0x5bc
```
|
@sh0rez You are right, it's a nuance I was not aware of the Changed my fix to keep |
maoueh
force-pushed
the
fix/error-target-must-be-non-null
branch
from
1e470c0 to
6efd38c
Compare
julienduchesne
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an API server for which I'm not authentified with correctly,
tankawould panic withtarget must be a non-nil pointerbecause of a call toerrors.As. Since we are actually only checking the type of the error and not its content,errors.Iscan be used here. The It could also be moved to a variable to avoid creating a new instance each time just to check if it's of the right type.This was happening trying to show the diff because it seems I'm not configured correctly.