Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match Add() and AddRepos() and correct typos #641

Merged
merged 3 commits into from
Nov 11, 2021
Merged

match Add() and AddRepos() and correct typos #641

merged 3 commits into from
Nov 11, 2021

Conversation

julienduchesne
Copy link
Member

Supersedes #640 (adding unit tests)

sh0rez
sh0rez reviewed Nov 9, 2021
View reviewed changes
pkg/helm/charts.go Outdated Show resolved Hide resolved
@julienduchesne julienduchesne requested a review from a team November 10, 2021 11:59
@redradrat
Copy link
Contributor

@julienduchesne thx for helping out my lazy ass with the tests here ;)

@redradrat redradrat mentioned this pull request Nov 11, 2021
Closed
jvrplmlmn
jvrplmlmn approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julienduchesne julienduchesne merged commit 2aea03e into main Nov 11, 2021
@julienduchesne julienduchesne deleted the redradrat/main branch November 11, 2021 21:38
@julienduchesne julienduchesne mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez left review comments

@jvrplmlmn jvrplmlmn jvrplmlmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienduchesne @redradrat @jvrplmlmn @sh0rez