Allow partial matches in the --name option #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Say I get this output: ``` $ tk diff tanka/environments/my-project Error: found multiple Environments in 'tanka/environments/my-project': - environments/my-project/dev - environments/my-project/prod ``` I can now rerun this command with `--name dev` or `--name ops` instead of the whole environment name When more than one environment matches, the same message as before is given
Duologic
approved these changes
Oct 1, 2021
julienduchesne
added a commit
that referenced
this pull request
Oct 5, 2021
🤦 From #613 If there are two environments and one's name is a superset of the first, there is no longer a way to target the one with the smaller name because they will both be targeted with the smaller name I think it has to be a pretty rare issue but it'd be good to have this in next release
julienduchesne
added a commit
that referenced
this pull request
Oct 5, 2021
) * fix: If there's a full match on an inline environment name, use it :facepalm: From #613 If there are two environments and one's name is a superset of the first, there is no longer a way to target the one with the smaller name because they will both be targeted with the smaller name I think it has to be a pretty rare issue but it'd be good to have this in next release * Better tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say I get this output:
I can now rerun this command with
--name devor--name opsinstead of the whole environment nameWhen more than one environment matches, the same message as before is given