feat: Add support to specify --kube-version in Helm template
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
approved these changes
Jul 2, 2021
Duologic
changed the title
--kube-version in Helm template--kube-version in Helm template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support to specify a custom Kubernetes version when using
helmfeature.It would enable to use helm charts such as this for older kubernetes version easier. We use
tk exportin CI (docker). Thus, helm cannot detect server's version and fall back to default built-in.As workaround, I downgraded the helm to the version where buit-in KubeVersion matches k8s version of the k8s clusters.
It would be much nicer to define the k8s version natively.