feat(api): Environment discovery #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
commented
Jan 7, 2021
Duologic
reviewed
Jan 7, 2021
|
#467 is approved, please merge it and rebase this PR so we can review the changes properly. |
Merged
Introduces `tanka.ListEnvs` for discovering all nested environments starting from any given directory on the filesystem. This is now implemented by concurrently testing each subfolder of the given directory as to whether it is a valid environment. The recursion stops if any directory is a valid environment.
Switches all occurences of `FindBaseDirs` to the more performant `ListEnvs` algorithm. A quick `tk env list` test gave the following: ``` Before: tk env list 25.40s user 0.69s system 946% cpu 2.757 total After: tk env list 1.61s user 0.37s system 811% cpu 0.243 total ```
Duologic
approved these changes
Jan 8, 2021
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
tanka.ListEnvsfor discovering all nested environments starting from any given directory on the filesystem.This is now implemented by concurrently testing each subfolder of the given directory as to whether it is a valid environment. The recursion stops if any directory is a valid environment.
Switches all occurences of
FindBaseDirsto the more performantListEnvsalgorithm.A quick
tk env liston our config repo gave the following:Needs rebasing on #467 once merged