fix(jpath): support nested calling again #456
Merged
+350
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, Tanka was able to find the environments entrypoint, even when it was actually called on a directory that is nested underneath that environment. This was modeled after the ability to use `git` commands anywhere in the project. This functionality was lost however in a recent PR. While restoring it, I took the chance to do a long overdue refactoring of the `jpath` package.
sh0rez
added
kind/bug
jvrplmlmn
reviewed
Dec 30, 2020
Duologic
approved these changes
Dec 30, 2020
Comment on lines
+26
to
+32
| root, err := FindParentFile("tkrc.yaml", start, stop) | ||
| if err == nil { | ||
| return root, nil | ||
| } | ||
|
|
||
| // otherwise use jsonnetfile.json | ||
| root, err = FindParentFile("jsonnetfile.json", start, stop) |
There was a problem hiding this comment.
nit: Can we have a list of parentFiles []string and iterate over it? It could make the jsonnet/jpath API a bit more flexible.
There was a problem hiding this comment.
Where would that go? I would not want every callee of jpath.Resolve or jpath.FindRoot have to specify that
There was a problem hiding this comment.
Merging, we can address that later if we wish to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, Tanka was able to find the environments entrypoint, even when it was actually called on a directory that is nested underneath that environment.
This was modeled after the ability to use
gitcommands anywhere in the project.This functionality was lost however in a recent PR (#389)
While restoring it, I took the chance to do a long overdue refactoring of the
jpathpackage.